Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(jruby) namespaced attributes #2679

Merged
merged 2 commits into from
Jun 24, 2024
Merged

(jruby) namespaced attributes #2679

merged 2 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. test: add coverage for namespaced attributes 

    including a failing test for JRuby round-trip of an attribute
    @flavorjones
    flavorjones committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d20cd17 View commit details
    Browse the repository at this point in the history

  2. fix(jruby): Node#attribute correctly matches against localName 

    Previously, it was matching against the full name.

Also, make sure that we create new attributes with
setAttributeNS (even if the URI is null) so that we can retrieve with
`localName`. Note that we need additional logic to handle unknown
namespaces.
    @flavorjones
    flavorjones committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c142785 View commit details
    Browse the repository at this point in the history