dep: update libxml to 2.12.0 (with explicit -lpthread linkline)
#3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
flavorjones
force-pushed
the
fj-dep-libxml-2.12.0
branch
from
b43e300
to
f12e955
Compare
because extconf contains the recipe by which libxml2/libxslt are built
though note that libxslt was also previously updated to 1.1.39 on the v1.15.x branch. - https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0 - https://gitlab.gnome.org/GNOME/libxslt/-/releases/v1.1.39
libxml 2.12 has a hard dependency on pthread symbols on older systems with glibc version < 2.34. note that we also remove the patch for libxml threaded support from 2.11, since we're now explicitly specifying libpthread.
flavorjones
force-pushed
the
fj-dep-libxml-2.12.0
branch
from
6e005d2
to
e6314df
Compare
flavorjones
force-pushed
the
fj-dep-libxml-2.12.0
branch
from
69a94a1
to
b0caa7c
Compare
flavorjones
force-pushed
the
fj-dep-libxml-2.12.0
branch
from
b0caa7c
to
985d15b
Compare
because link-time behavior is important for the libpthread changes being made.
|
OK, so just a summary of what's going on in this PR as of 985d15b ...
The error on musl systems is: which I think is being pulled in by explicitly linking to libpthread on a glibc system. See #3031 for discussion on this and alternative approaches. |
flavorjones
changed the title
-lpthread linkline)
|
Closing because #3032 is a more promising approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Closes #3031
update libxml to 2.12.0 and libxslt to 1.1.39, though note that libxslt was also previously updated to 1.1.39 on the v1.15.x branch (#3025)
This approach attempts to explicitly link with
-lpthreadto handle libxml2 changes to thread local storage. See #3031 for more discussion.