dep: libxml 2.12.0 upgrade (with libxml2 patch for weakref) #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
fj-dep-libxml-2.12.0_patch-weakref
branch
2 times, most recently
from
7f4a743
to
9c9c99c
Compare
|
CI didn't kick off, so the manual run is https://github.com/sparklemotion/nokogiri/actions/runs/6916120729 |
because extconf contains the recipe by which libxml2/libxslt are built
because link-time behavior is important for the libpthread changes being made.
though note that libxslt was also previously updated to 1.1.39 on the v1.15.x branch. - https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0 - https://gitlab.gnome.org/GNOME/libxslt/-/releases/v1.1.39
|
OK, so even with the patches applied, we're still pulling in You can read more about TLS at https://maskray.me/blog/2021-02-14-all-about-thread-local-storage Turning off TLS by configuring libxml2 with |
Using thread-local variables in position-independent code (i.e., combining `__thread` variables with the `-fPIC` compiler option) introduces a (non-weak) reference to `__tls_get_addr` which resolves to `ld-linux` on glibc systems and `libwinpthread` on windows systems. This is an issue when precompiling for musl on glibc systems. If and when we can build a separate musl native gem, we can revisit this decision.
flavorjones
force-pushed
the
fj-dep-libxml-2.12.0_patch-weakref
branch
from
9c9c99c
to
004e6a6
Compare
|
This seems like the winner. |
tagliala
added a commit
to tagliala/premailer
that referenced
this pull request
Jan 18, 2024
There have been two recent changes in libxml2 2.11 and than 2.12 which broke two specs related to the conversion of UTF-8 chars. This commit sets the minimum required Nokogiri version to 1.16 which bundles libxml2 2.12, in order to have a predictable behaviour. References: - premailer#430 - sparklemotion/nokogiri#2965 - sparklemotion/nokogiri#3032 - GNOME/libxml2@f1c1f5c - GNOME/libxml2@37cedc0 Close premailer#443
tagliala
added a commit
to tagliala/premailer
that referenced
this pull request
Jan 18, 2024
There have been two recent changes in libxml2 2.11 and than 2.12 which broke two specs related to the conversion of UTF-8 chars. This commit sets the minimum required Nokogiri version to 1.16 which bundles libxml2 2.12, in order to have a predictable behaviour. References: - premailer#430 - sparklemotion/nokogiri#2965 - sparklemotion/nokogiri#3032 - GNOME/libxml2@f1c1f5c - GNOME/libxml2@37cedc0 Close premailer#443
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#3031
This approach uses the patches submitted upstream at:
and turns off libxml2's thread-local storage feature, which is an issue when precompiling for musl on glibc systems. If and when we can build a separate musl native gem, we can revisit this decision.