Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handle upstream libxml2 error message changes #3109

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

Upstream libxml2 (pre-2.13) is changing some error messages. Let's make the tests more robust around those messages.

@flavorjones flavorjones changed the title Flavorjones 20240122 upstream libxml2 test: handle upstream libxml2 error message changes Jan 22, 2024
@flavorjones
Copy link
Member Author

flavorjones commented Jan 22, 2024

upstream workflow run is: https://github.com/sparklemotion/nokogiri/actions/runs/7618098281 (which is green)

@flavorjones flavorjones merged commit 3673f77 into main Jan 22, 2024
141 of 142 checks passed
@flavorjones flavorjones deleted the flavorjones-20240122-upstream-libxml2 branch January 22, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant