Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch publish #2

Open
5 tasks
mdwaud opened this issue May 4, 2022 · 0 comments
Open
5 tasks

Support batch publish #2

mdwaud opened this issue May 4, 2022 · 0 comments

Comments

@mdwaud
Copy link
Collaborator

mdwaud commented May 4, 2022

A lot of work has gone into this already and you can see the batch encoder {here](https://github.com/sparkmeter/sink/blob/main/lib/sink/connection/protocol/batch.ex).

Remaining Work

  • Implement Switch from fixed packet size to varint #1
  • Add new Sink "advanced request" and "advanced response" message type(s) to support batch operations
  • Determine interface changes to handlers (do we return the whole batch or one event at a time?
  • Determine how to structure response of batches with NACKs
  • Make batches aware of message ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant