Checksum for boxes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication, FileSystemBoxRepository modification and test modification.
sparkoo
reviewed
Jul 3, 2017
|
|
||
| import java.io.File; | ||
|
|
||
| public class BlankHashService implements HashService{ |
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| return true; |
|
|
||
| public interface HashService { | ||
| String getHashType(); | ||
| String getChecksum(File file); |
There was a problem hiding this comment.
Argument should not be File. For example when we save hashes to database and get them from there.
So maybe make parameter as generic type and implementation DigestHashService should type it as File and should be renamed to DigestFileHashService? Or something that would ensure better extensibility than this.
sparkoo
reviewed
Jul 3, 2017
|
|
||
| public class HashServiceFactory { | ||
|
|
||
| public HashService createHashService(String algorithm) throws NoSuchAlgorithmException { |
There was a problem hiding this comment.
To simplify, this can be static method in DigestHashService
… static, not including of null properties of BoxProvider to JSON
|
All comments should be fixed. |
sparkoo
reviewed
Jul 7, 2017
| bytes = getByteArrayFromFile(file); | ||
| } catch (IOException e) { | ||
| LOG.error("Error during processing file [{}], message: [{}]", file, e.getMessage()); | ||
| return ""; |
…ethod when IOException is encountered
|
ok, thanks! |
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.