FontAwesome 5 compatibility #665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionaru
commented
Dec 2, 2017
•
Ionaru
commented
- Icons from FA5 should now work, but you have to use the fa-v4-shims to get all the icons right.
- FA4 icons still work like they used to.
- Fixes FontAwesome 5 compatibility #664
* Icons from FA5 should now work, but you have to use the fa-v4-shims to get all the icons right. * FA4 icons still work like they used to.
|
Not sure what's up with the tests, afaik I didn't change anything in that long scary isMobile function. Can @WesCossick look into this? |
* Removed redundant escapes from isMobile regex and some others. * Added fa-heading class to heading icon so it works on FA5. * Changed fa-picture-o to fa-image so it works on FA5. * Added noDisable flag for icons that is then handled in the createIcon function. * Changed 'http://' default for links to 'https://'. * Added noDisable to guide icon. * Removed opacity change on toolbar hover (was 0.6). * Removed opacity default (was 0.8). * Removed default icon color (was #2c3e50). * Added opacity change to disabled buttons, they get opacity of 0.6 when disabled. * Added Node 8 and Node 9 support. * Removed Node 0.12 and Node 5 support.
|
Closing this because I made a new PR on the develop branch. ( #666 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.