Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome 5 compatibility #666

Open
wants to merge 3 commits into
base: development
from

Conversation

@Ionaru
Copy link

commented Dec 4, 2017

Added compatibility for FontAwesome 5 by creating a seperate element for the icon and nesting it inside the button element instead of putting the classes on the button element. This makes sure that the button and all its properties stays intact when FontAwesome 5 changes elements to <svg> for their icons.

FontAwesome 4 works with this change as well. There are no visual differences except that the icon has shifted 1px up, probably because of some centering by FontAwesome.

Fixes #664

@Ionaru Ionaru referenced this pull request Dec 4, 2017
@johndodev

This comment has been minimized.

Copy link

commented Jan 23, 2018

Need plz !

@Ionaru

This comment has been minimized.

Copy link
Author

commented Jan 24, 2018

This has been implemented in my fork of the project: https://github.com/Ionaru/easy-markdown-editor

@Jetski5822

This comment has been minimized.

Copy link

commented Aug 17, 2018

Any chance this could be added in?

@atodorov

This comment has been minimized.

Copy link

commented Nov 8, 2018

Is there anyone who wants to co-maintain this package? I've pinged the original authors to see if they need help but my expertise is in other languages so would appreciate backup.

@Ionaru Ionaru referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.