Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional.orThrow(Exception)? #41

Closed
Tracked by #40
Sparky983 opened this issue Sep 19, 2023 · 1 comment
Closed
Tracked by #40

Optional.orThrow(Exception)? #41

Sparky983 opened this issue Sep 19, 2023 · 1 comment

Comments

@Sparky983
Copy link
Owner

No description provided.

@Sparky983 Sparky983 mentioned this issue Sep 19, 2023
3 tasks
@Sparky983
Copy link
Owner Author

Adding this method would encourage the following usage:

Optional.present(10)
    .orThrow(new RuntimeException("test"))

which has the hidden cost of calling the expensive Throwable.fillInStackTrace().

This may be useful in situations where you may want to continue after catching an error if a value is present. Take the following example:

try {
  doSomething()
} catch (Exception thrown) {
  var errorHandler = this.errorHandler.orThrow(thrown);
  errorHandler.handle(thrown);
}

I don't think this is very common however, and it isn't much harder to write orThrow(() -> thrown).

@Sparky983 Sparky983 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant