Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSEventStreamScheduleWithRunLoop has been deprecated in MacOS 13 #163

Closed
Cogitri opened this issue Jul 5, 2023 · 3 comments
Closed

FSEventStreamScheduleWithRunLoop has been deprecated in MacOS 13 #163

Cogitri opened this issue Jul 5, 2023 · 3 comments
Assignees
@SpartanJ

Comments

@Cogitri
Copy link

Cogitri commented Jul 5, 2023

Hello,

after updating our AppleClang, we've noticed that efsw uses deprecated functionality on MacOS:

src/efsw/WatcherFSEvents.cpp:67:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
        FSEventStreamScheduleWithRunLoop( FSStream, FWatcher.load()->mRunLoopRef.load(),
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here
FSEventStreamScheduleWithRunLoop(
^
1 warning generated.
@SpartanJ SpartanJ self-assigned this Jul 5, 2023
@SpartanJ
Copy link
Owner

SpartanJ commented Jul 5, 2023

Thank you for reporting it. I'll make the necessary changes soon.

@Cogitri
Copy link
Author

Cogitri commented Jul 5, 2023

Grand, thanks! :)

SpartanJ added a commit that referenced this issue Jul 18, 2023
@SpartanJ
Fix issue #163.
ac1a2fc 
It seems that using the old method can cause crashes on macOS Ventura. So this is a critical change and all users should update to this new version. I'll test a few days and create a new release tag if everything is working fine.
@SpartanJ
Copy link
Owner

This should be fixed since this commit. I'll continue testing a little bit more and tag a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpartanJ SpartanJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpartanJ @Cogitri