Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efsw does not work properly with CIFS/samba mounts #73

Closed
SpartanJ opened this issue Sep 25, 2014 · 3 comments
Closed

efsw does not work properly with CIFS/samba mounts #73

SpartanJ opened this issue Sep 25, 2014 · 3 comments
Labels
bug Something isn't working major

Comments

@SpartanJ
Copy link
Owner

Original report by Greg Lee (Bitbucket: glee_hokie, ).


efsw reports EOVERFLOW when a directory on a CIFS/samba mount is specified as a monitor point. The reason is that CIFS mounts require a larger return structure for the stat() function. The solution is to #define _FILE_OFFSET_BITS 64 in the two files that call stat() - FileInfo.cpp and platform/posix/FileSystemImpl.cpp.

Here's a link that should fill you in on this (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=604928).

FYI, you must use the generic monitor with CIFS mounts since they do not support the inotify API.

@SpartanJ
Copy link
Owner Author

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Thanks for reporting it.
I'll take a look to this in some days, since i'm not with time right now.

It would be interesting to detect if the directory is an cifs or NFS mount and fallback automatically to the generic watcher.

@SpartanJ
Copy link
Owner Author

SpartanJ commented Nov 7, 2014

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Applied a patch to avoid the EOVERFLOW error.

I still need to implement the fallback to the generic watcher if the directory watched is in a remote file system.

To implement this I’ll need to use statvfs, but the implementation differs between operating systems.

As reference on how to implement this we can look at the GNU stat from coreutils source code.

@SpartanJ
Copy link
Owner Author

SpartanJ commented Nov 9, 2014

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Fixed issue #33.

@SpartanJ SpartanJ closed this as completed Nov 9, 2014
@SpartanJ SpartanJ added major bug Something isn't working labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant