Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python simulate() change in behaviour in sme 1.0.9 #475

Closed
lkeegan opened this issue Apr 8, 2021 · 0 comments · Fixed by #476
Closed

python simulate() change in behaviour in sme 1.0.9 #475

lkeegan opened this issue Apr 8, 2021 · 0 comments · Fixed by #476
Labels
bug Something isn't working python Python library

Comments

@lkeegan
Copy link
Member

lkeegan commented Apr 8, 2021

Previously to version 1.0.9 of sme, model.simulate() would always start a new simulation of the model from the initial model concentrations.

Because of the improvements to simulation in #470, in version 1.0.9 calling simulate() for a second time on the same model does something different:

  • the simulation continues from where it was, not from the original model state
  • but the previous simulation data is not added to the results on the python side, only the new results are visible

We should revert to the previous behaviour for now, i.e. explicitly clear any SimulationData before each simulation, to avoid breaking any existing python code that expects multiple simulate calls to the same model to be independent of each other.

@lkeegan lkeegan added bug Something isn't working python Python library labels Apr 8, 2021
lkeegan added a commit that referenced this issue Apr 8, 2021
…nterface

- resolves #475
- fix example simulation notebook to avoid this issue
lkeegan added a commit that referenced this issue Apr 8, 2021
…nterface (#476)

- resolves #475
- fix example simulation notebook to avoid this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Python library
Projects
None yet
1 participant