Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene graph implementation #986

Merged
merged 32 commits into from
May 15, 2024
Merged

Scene graph implementation #986

merged 32 commits into from
May 15, 2024

Conversation

nashmit
Copy link
Contributor

@nashmit nashmit commented May 8, 2024

An interface/class implementation for affine transformations from which all the objects from the scene ( camera, geometry, planes, lights, debug info/geometry ) will be inherited. Each object should be able to change its reference frame.

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 88.95%. Comparing base (8039f4d) to head (b3287af).

Files Patch % Lines
gui/rendering/Node.cpp 91.46% 7 Missing ⚠️
gui/widgets/qopenglmousetracker.cpp 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   89.29%   88.95%   -0.34%     
==========================================
  Files         144      145       +1     
  Lines       14360    14417      +57     
==========================================
+ Hits        12823    12825       +2     
- Misses       1537     1592      +55     
Flag Coverage Δ
cli 22.19% <0.00%> (-0.10%) ⬇️
core 49.20% <0.00%> (-0.20%) ⬇️
gui 70.28% <90.00%> (-0.27%) ⬇️
mainwindow 40.77% <8.57%> (-0.37%) ⬇️
sme 28.31% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nashmit nashmit self-assigned this May 8, 2024
@nashmit nashmit linked an issue May 8, 2024 that may be closed by this pull request
3 tasks
@nashmit nashmit requested a review from lkeegan May 13, 2024 13:09
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good, all minor comments

gui/rendering/Node.cpp Outdated Show resolved Hide resolved
gui/rendering/Node.cpp Show resolved Hide resolved
gui/rendering/Node.cpp Outdated Show resolved Hide resolved
gui/rendering/Node.cpp Outdated Show resolved Hide resolved
gui/rendering/Utils.cpp Outdated Show resolved Hide resolved
gui/widgets/qopenglmousetracker.cpp Outdated Show resolved Hide resolved
gui/widgets/qopenglmousetracker_t.cpp Show resolved Hide resolved
@nashmit nashmit changed the title Scene graph Scene graph implementation. May 14, 2024
@nashmit nashmit changed the title Scene graph implementation. Scene graph implementation May 14, 2024
@nashmit nashmit requested a review from lkeegan May 14, 2024 19:27
Copy link

sonarcloud bot commented May 14, 2024

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants