This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Add user friendly error when failing to find build config #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
size/S
jessicafalk
approved these changes
Apr 18, 2019
jared-improbable
approved these changes
Apr 23, 2019
workers/unity/Packages/com.improbable.gdk.buildsystem/WorkerBuilder.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.buildsystem/WorkerBuilder.cs
Outdated
Show resolved
Hide resolved
jamiebrynes7
force-pushed
the
feature/null-build-config-error
branch
from
e201e0e
to
8a6ac62
Compare
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Bugfix/increase ops tick rate (#914) * [UNR-1350] Bugfix: GenerateSchemaAndSnapshots: Run full schema gen once, then generate snapshots (#926) * Run full schema gen once, then generate snapshots * update changelog * Update changelog * Wrap launch config path with quotes in order to properly launch (#905) * Wrap launch config path with quotes in order to properly launch * Update CHANGELOG.md * [UNR-1303] Rename namespace improbable to SpatialGDK (#876) * Renamed improbable namespace to SpatialGDK * Removed legacy redefinition of IMPROBABLE_DLL_API for C++ SDK * Remove dead code related to generated C++ SDK code namespaces * Revert accidental change to schema generation code * Updated docs for non-unreal-server-worker-types to use new namespace * Consistency fixes (#880) * Consistency fixes * Fix name shadowing * UNR-1375: Save deduplicated schema names in schema db (#919) * Keep track of Schema Name collisions globally, including names of previously generated types * Added Changelog entry * [UNR-1371] Bugfix: Do not generate schema for assets in 'Directories to Never Cook' (#934) * Avoid Loading Assets & Selecting Classes that are in packages that are in UProjectPackagingSettings::DirectoriesToNeverCook * Added Changelog * PR Comments * Changelog typo * Add explicit check for != nullptr) * FindByPredicate -> ContainsByPredicate * [UNR 1415] Bugfix: Readonly Schema Database crashes editor during generation (#942) Try to load schema db first in schema gen. Check file exists & is writable, fail schema gen if not writable or asset loading fails * Update CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before building workers, we check whether we can find a SpatialOS Build Configuration instance. If not we:
This is instead of the user getting a null ref exception thrown somewhere inside the build process.
Tests
Deleted the asset. Tried to build. Saw popup + error in the terminal.
Documentation
Changelog.
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.