Add PHP 8.2 Support #199
Merged
Add PHP 8.2 Support #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
reviewed
Dec 7, 2022
| @@ -9,7 +9,7 @@ jobs: | |||
| fail-fast: true | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| php: [8.1, 8.0, 7.4] | |||
| php: [8.2, 8.1, 8.0, 7.4] | |||
There was a problem hiding this comment.
Suggested change
| php: [8.2, 8.1, 8.0, 7.4] | |
| php: ['8.2', '8.1', '8.0', '7.4'] |
There was a problem hiding this comment.
@sanmai Most of the other Spatie workflows are not quoted, so just curious - why this one? 🤔
There was a problem hiding this comment.
shivammathur/setup-phpexpects to see strings forphp-version.- There was an issue when it installed the really latest version if you didn't specify a string. I.e. for
8.0it used to install8.1.x.and for'8.0'it used to install8.0.x. But it looks like it is no longer an issue. - Lastly, it looks prettier in the log:
Feel free to disregard though.
|
ping @freekmurze |
|
I don't have a strong opinion on this, I'll take it 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds PHP 8.2 to the tests workflow.
id:php82-support/v1