Allow URL customisations for Google, Outlook and Yahoo #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alies-dev
changed the title
|
Hey @atymic. What do you think about this feature and the implementation? |
atymic
reviewed
Jan 30, 2024
| { | ||
| $link = $this->createShortEventLink(); | ||
|
|
||
| $this->assertMatchesSnapshot($link->google(['recur' => 'RRULE:FREQ=DAILY'])); |
There was a problem hiding this comment.
Oh google does support re-occuring!
Did you find documentation for the params?
There was a problem hiding this comment.
My company also maintains docs for services like Google calendar: https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/master/services/google.md
Links to these docs you can find on PHPDoc (class-level docs on generators)
There was a problem hiding this comment.
Ahh awesome. Didn't realise google support recurring rules. Shame other providers dont
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google, Outlook and Yahoo have custom GET parameters that it's currently not possible to set from Link class. This PR allow to add such parameters.