Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set dump binary path with empty value #206

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mokhosh
Copy link
Contributor

@mokhosh mokhosh commented Mar 30, 2024

Currently if no value gets passed to the setDumpBinaryPath because of different environment variables, you get this:

production.ERROR: Too few arguments to function Spatie\DbDumper\DbDumper::setDumpBinaryPath(), 0 passed

But this makes it possible to have a custom path in some environments, and set it back to default which is already an empty string when no parameters are passed.

@freekmurze freekmurze merged commit c566852 into spatie:main Apr 1, 2024
7 checks passed
@freekmurze
Copy link
Member

Thanks!

@mokhosh mokhosh deleted the allow-set-empty-path branch April 1, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants