Precedent input when typing ↑ #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
freekmurze
reviewed
Oct 29, 2017
resources/assets/js/app.js
Outdated
| input.addEventListener('keydown', event => { | ||
| if (event.keyCode === 38) { | ||
| input.value = history.getPrevious(); | ||
| } else if (event.keyCode === 40) { |
There was a problem hiding this comment.
Could you avoid else by making using of early returns?
freekmurze
reviewed
Oct 29, 2017
| } | ||
| } | ||
|
|
||
| export default History; |
There was a problem hiding this comment.
Make this file end with a newline.
|
It should be good now |
|
I just added a limit to the stored history so they won't have any problems in the future. |
Merged
|
Closing this as it's already included in #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here #5 , here is the PR :)