Behave like a terminal #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please PR your idea to fix backwards compatibility.
On Sun, 29 Oct 2017 at 18:22, Robin Choffardet ***@***.***> wrote:
This PR introduces a terminal-like behavior to the application as
suggested in #18 <#18>
Work is mostly done, but it introduces a breaking change : Shareable URL
now needs to have a Hash before the command like so :
http://dnsrecords.io/#google.fr
If it matters, I have an idea to ensure backward compatibility :)
UI isn't one of my skills, so don't hesitate to give me advice/tips on how
to improve it !
PS: Terminals have history so I included my previous work in #13
<#13>
------------------------------
You can view, comment on, or merge this pull request online at:
#20
Commit Summary
- ✨ add history feature
- Merge branch 'master' into master
- Merge branch 'master' into master
- 📝 merge submit event
- 📝 remove else keyword by making use of early return
- 📝 end file with a newline
- ✨ add limit to history (1000 elements max)
- ✨ behave like a terminal
File Changes
- *M* app/Http/Controllers/HomeController.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-0> (1)
- *M* app/Services/Commands/CommandChain.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-1> (2)
- *D* app/Services/Commands/Commands/Clear.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-2> (19)
- *M* app/Services/Commands/Commands/DnsLookup.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-3> (12)
- *D* app/Services/Commands/Commands/Doom.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-4> (19)
- *M* app/Services/Commands/Commands/Ip.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-5> (7)
- *M* app/Services/Commands/Commands/Localhost.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-6> (7)
- *M* app/Services/Commands/Commands/Manual.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-7> (7)
- *M* resources/assets/css/base/headings.css
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-8> (1)
- *A* resources/assets/js/History.js
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-9> (49)
- *M* resources/assets/js/app.js
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-10> (15)
- *A* resources/assets/js/bootstrap.js
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-11> (13)
- *A* resources/assets/js/components/terminal.vue
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-12> (119)
- *M* resources/views/home/index.blade.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-13> (37)
- *D* resources/views/layout/_partials/flash.blade.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-14> (10)
- *M* resources/views/layout/master.blade.php
<https://github.com/spatie/dnsrecords.io/pull/20/files#diff-15> (1)
Patch Links:
- https://github.com/spatie/dnsrecords.io/pull/20.patch
- https://github.com/spatie/dnsrecords.io/pull/20.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#20>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdiDYHk4Ae7b4KaNrNBrTght3sPxqwWks5sxLRsgaJpZM4QKZS8>
.
--
Freek Van der Herten https://spatie.be +32 495 84 27 91
|
|
Will you accept a redirection (from |
|
Redirection is fine
On Sun, 29 Oct 2017 at 20:04, Robin Choffardet ***@***.***> wrote:
Will you accept a redirection (from 'dnsrecords.io/google.fr' to '
dnsrecords.io/#google.fr') or do you need the exact same feature ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdiDW9zl4K9zPAQEzkqB9lIg3hJP3p-ks5sxMxNgaJpZM4QKZS8>
.
--
Freek Van der Herten https://spatie.be +32 495 84 27 91
|
|
Done :) |
|
Thanks! Pulling it into a separate branch to play a bit with it. |
|
After having toyed around with it, we decided not to pull it in. Mainly because having results for multiple domains on the screen comes over as messy and might confuse users. But thank you anyways for the work you put into this. |
|
OK no problem. |
|
For the sake of simplicity, we are going to leave things as they are now and not implement stuff around getting the previous command. We might reconsider it in the future. |
|
ok ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a terminal-like behavior to the application as suggested in #18
Work is mostly done, but it introduces a breaking change : Shareable URL now needs to have a Hash before the command like so :
http://dnsrecords.io/#google.frIf it matters, I have an idea to ensure backward compatibility :)
UI isn't one of my skills, so don't hesitate to give me advice/tips on how to improve it !
PS: Terminals have history so I included my previous work in #13
I also added the
history -ccommand to clear history, I can change it to 'clear-history' or anything else.