Add Estonian holidays #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Countries/Estonia.php
Outdated
| return 'ee'; | ||
| } | ||
|
|
||
| /** @return array<string, string|CarbonImmutable> */ |
src/Countries/Estonia.php
Outdated
| /** @return array<string, CarbonImmutable> */ | ||
| protected function variableHolidays(int $year): array | ||
| { | ||
| $easter = CarbonImmutable::createFromTimestamp(easter_date($year)) |
There was a problem hiding this comment.
use $this->easter($year) instead. Only available after rebasing your branch on our main branch.
|
rebased, north macedonia test fails |
|
Thanks! |
Crawford30
pushed a commit
to Crawford30/holidays
that referenced
this pull request
Jan 19, 2024
* Add Estonian holidays * Use easter() method for easter date
ssmusoke
pushed a commit
to ssmusoke/holidays
that referenced
this pull request
Jan 20, 2024
* Add Estonian holidays * Use easter() method for easter date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
National holidays and days of importance