-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Turkey holidays #70
Conversation
Not implemented islamic dates, you can convert gregorian to hijri calendar |
Thanks! Can you rebase from main, so I can run the tests here? |
@Nielsvanpach I did it. Can you run the tests? |
Thanks, this PR looks good! |
No library or built-in php intl functions convert dates properly for all years, including “geniusts/hijri-dates”. If you accept, it is most logical to prepare the dates between 1970 and 2037 as a constant class for Islamic holidays. Because Islamic holidays predicted and actual dates may change until the last moment. https://en.wikipedia.org/wiki/Eid_al-Fitr?wprov=sfti1#In_the_Gregorian_calendar https://en.wikipedia.org/wiki/Eid_al-Adha?wprov=sfti1#In_the_Gregorian_calendar |
PR is done. Can you check please ?
|
@Nielsvanpach Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before. So can you merge this PR ? |
Thanks for your work on this @thecaliskan ! |
No description provided.