Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Turkey holidays #70

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Added Turkey holidays #70

merged 13 commits into from
Jan 23, 2024

Conversation

thecaliskan
Copy link
Contributor

No description provided.

@paramientos
Copy link

Not implemented islamic dates, you can convert gregorian to hijri calendar

@Nielsvanpach
Copy link
Member

Thanks! Can you rebase from main, so I can run the tests here?

@thecaliskan
Copy link
Contributor Author

@Nielsvanpach I did it. Can you run the tests?

@Nielsvanpach
Copy link
Member

Thanks, this PR looks good!
I'm still hesitant to merge countries with Islamic holidays. I would prefer to have a good solution on the lunar based holidays first.

@thecaliskan
Copy link
Contributor Author

thecaliskan commented Jan 19, 2024

Hi @Nielsvanpach

No library or built-in php intl functions convert dates properly for all years, including “geniusts/hijri-dates”. If you accept, it is most logical to prepare the dates between 1970 and 2037 as a constant class for Islamic holidays. Because Islamic holidays predicted and actual dates may change until the last moment.

https://en.wikipedia.org/wiki/Eid_al-Fitr?wprov=sfti1#In_the_Gregorian_calendar

https://en.wikipedia.org/wiki/Eid_al-Adha?wprov=sfti1#In_the_Gregorian_calendar

@thecaliskan
Copy link
Contributor Author

thecaliskan commented Jan 20, 2024

Hi @Nielsvanpach

PR is done. Can you check please ?

No library or built-in php intl functions convert dates properly for all years or all country including “geniusts/hijri-dates”. It is most logical to prepare the dates between 1970 and 2037 as a constant property for Islamic holidays. Because Islamic holidays predicted and actual dates may change until the last moment. Since the information on wikipedia is incorrect, it was obtained by searching the old calendar on Google Images for each year. The accuracy of the information has been double checked. Ramadan and Sacrifice holidays vary for Turkey and other countries. A converter algorithm that will cover all years does not seem possible.

@thecaliskan
Copy link
Contributor Author

@Nielsvanpach Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before. So can you merge this PR ?

@Nielsvanpach
Copy link
Member

Thanks for your work on this @thecaliskan !

@Nielsvanpach Nielsvanpach merged commit f9423cf into spatie:main Jan 23, 2024
8 checks passed
@Nielsvanpach Nielsvanpach mentioned this pull request Jan 30, 2024
@wessama wessama mentioned this pull request Feb 3, 2024
@Nielsvanpach Nielsvanpach mentioned this pull request Feb 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants