Use data_get()
for placeholder replacement instead of Arr::get()
#1038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the usage of
Arr::get()
withdata_get()
for retrieving placeholder values, so model properties (and deeply nested properties) can be logged.Problem
In the documentation it states:
However, this is not the case, as model properties cannot be reached with placeholders -- only model attributes.
Also, calling
$model->toArray()
inadvertently executes and caches model accessors via the$appends
property, which can cause unneeded overhead if a developer has configured queries to be executed in these accessors.This PR resolves the above issues by using Laravel's
data_get()
helper, which reaches into objects (and deeply nested objects) via dot-notated key.