Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non backed enum & php 8.1 #1110

Merged
merged 11 commits into from
Nov 10, 2022
Merged

Support non backed enum & php 8.1 #1110

merged 11 commits into from
Nov 10, 2022

Conversation

pemudakoding
Copy link

@pemudakoding pemudakoding commented Nov 4, 2022

Hello.

yesterday I opened issue with Bug label, because I'm working with non backed enum, it seems cannot work properly, when logging to the package it will return exception I assume package issue, because I'm working with Laravel 9 it pass the data well

here the issue
👍 Activity log cannot produce enum on properties (array)

This one the first time to try contribute on Open source project, I hope you can support me, so if I have any mistake / wrong on code side etc let me know and learn and help this community as well.

Thanks.

composer.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution - and welcome to the open-source world! 🎉
Just a few small change requests - and good work for finding and using the getStorableEnumValue() method. 🚀

@pemudakoding
Copy link
Author

Hey, thanks for your contribution - and welcome to the open-source world! 🎉 Just a few small change requests - and good work for finding and using the getStorableEnumValue() method. 🚀

Hi thanks your made my energy to go the contribution for further.
The request review has been resolv

@Gummibeer
Copy link
Collaborator

Thanks for all the reworks of the skip() logic - this is looking good now.

@Gummibeer Gummibeer merged commit e2cc899 into spatie:main Nov 10, 2022
@Gummibeer
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants