Control logging when there is no changes #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2019
Gummibeer
requested changes
Apr 10, 2019
|
Hey, thanks for your effort! I've seen some codestyle and standard issues. But don't know if it's still simple enough for this package @freekmurze ? |
Gummibeer
requested changes
Apr 10, 2019
|
The StyleCI check still fails @akoSalman can you fix it? |
Apply fixes from StyleCI
Gummibeer
requested changes
Apr 11, 2019
Gummibeer
approved these changes
Apr 11, 2019
|
When do you merge? I need this new feature😊 |
|
I think that I will have time tomorrow. Will comment the new release. Thanks so far! |
|
@Gummibeer Can you please merge this PR? I need to use it now in my project. Thanks. |
|
@akoSalman could you add this to the docs https://docs.spatie.be/laravel-activitylog/v3/advanced-usage/logging-model-events ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you don't want to save logs that have no changes.
To use this feature you must set below properties on your model.