Update create_activity_log_table.php.stub #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of the bigInteger methods that Laravel 5.8 uses by default
Gummibeer
requested changes
May 15, 2019
| $table->string('log_name')->nullable(); | ||
| $table->text('description'); | ||
| $table->integer('subject_id')->nullable(); | ||
| $table->bigInteger('subject_id')->nullable(); | ||
| $table->string('subject_type')->nullable(); | ||
| $table->integer('causer_id')->nullable(); |
|
Should we change the the subject and causer also to unsigned? |
|
@freekmurze opinion? I would release this with #525 together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the bigInteger methods that Laravel 5.8 uses by default