-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/snake case relationships #602
Feature/snake case relationships #602
Conversation
In order to test correct behaviour of "snake case" defined relationships, we need a relationship which can be snake cased in this test model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care! 😊
Have some questions added.
Since already camelized strings are not modified, we could leverage the Str::camel helper in any case and remove the unnecessary conditional, checking if the source string is in camel case.
Renamed the relationship SnakeUser() to snakeUser() and moved to the anonymous class within the test.
Happy to help out this Hacktober 😉 I hope to have addressed your points in my latest commits to this PR. |
Thanks for changing it! 💙 |
👍 |
fixes #499
Addressing issue #499
snake_cased relationship definitions within
$logAttributes
are now handled correctly.