Feature/snake case relationships #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 2, 2019 12:05
In order to test correct behaviour of "snake case" defined relationships, we need a relationship which can be snake cased in this test model.
Gummibeer
reviewed
Oct 2, 2019
added 2 commits
October 2, 2019 14:03
Since already camelized strings are not modified, we could leverage the Str::camel helper in any case and remove the unnecessary conditional, checking if the source string is in camel case.
Renamed the relationship SnakeUser() to snakeUser() and moved to the anonymous class within the test.
Happy to help out this Hacktober 😉 I hope to have addressed your points in my latest commits to this PR. |
Gummibeer
approved these changes
Oct 2, 2019
|
Thanks for changing it! 💙 |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #499
Addressing issue #499
snake_cased relationship definitions within
$logAttributesare now handled correctly.