Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt backup archives v7 #1246

Merged
merged 6 commits into from
Mar 4, 2021

Conversation

patinthehat
Copy link
Contributor

This PR submits a port of #1239 for v7 (the original PR adds support for encrypting backup archives for for v6). All changes from #1239 have been updated to work with v7.

As with the original PR, there are also some minor updates to the installation-and-setup docs.

Resolves #1245.

@freekmurze @Gummibeer

@freekmurze
Copy link
Member

Looks good! Have you also tested this manually, just to be sure that you can decrypt the zips with the right password?

@patinthehat
Copy link
Contributor Author

Looks good! Have you also tested this manually, just to be sure that you can decrypt the zips with the right password?

Yes. I was able to decrypt the zips with the correct password without any issues.

@Gummibeer
Copy link
Contributor

As you've asked: for me as Mac user the only problem was that the default Archive/Zip application on macOS isn't able to extract encrypted archives.
So I had to use another application (Unarchiver) but it was the same for all archives, so seems like a problem with the app and not the packages logic.

@freekmurze freekmurze merged commit de5bf11 into spatie:master Mar 4, 2021
@freekmurze
Copy link
Member

Thank you very much!

@drbyte
Copy link
Contributor

drbyte commented Mar 4, 2021

I tested it on the v6 branch and BetterZip (Mac) can read the archives fine after prompting for the password.
Clarification: zips created and encrypted on ubuntu server via this package; and I unzipped on my Mac using BetterZip

@Gummibeer
Copy link
Contributor

Yeah, it's only the default program used by right-click "compress" on a folder too.
It just fails with an error and says that the ZIP is corrupted - which isn't the case! The program is simply unable to open encrypted archives. 😂

Possibly worth a note on the docs => will send PRs.

@drbyte
Copy link
Contributor

drbyte commented Mar 4, 2021

default Archive/Zip application on macOS isn't able to extract encrypted archives

I confirm the same symptom using the default macOS Archive application. (In my case macOS 10.14/Mojave.)

(It can handle unencrypted archives fine. I'm certain this is not an issue with this package's encryption feature.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port "Allow to encrypt backup archives" PR to v7
4 participants