-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypt backup archives v7 #1246
Encrypt backup archives v7 #1246
Conversation
…nd-setup to be in sync with the current config file options
Looks good! Have you also tested this manually, just to be sure that you can decrypt the zips with the right password? |
Yes. I was able to decrypt the zips with the correct password without any issues. |
As you've asked: for me as Mac user the only problem was that the default Archive/Zip application on macOS isn't able to extract encrypted archives. |
Thank you very much! |
I tested it on the v6 branch and BetterZip (Mac) can read the archives fine after prompting for the password. |
Yeah, it's only the default program used by right-click "compress" on a folder too. Possibly worth a note on the docs => will send PRs. |
I confirm the same symptom using the default macOS Archive application. (In my case macOS 10.14/Mojave.) (It can handle unencrypted archives fine. I'm certain this is not an issue with this package's encryption feature.) |
This PR submits a port of #1239 for
v7
(the original PR adds support for encrypting backup archives for forv6
). All changes from #1239 have been updated to work withv7
.As with the original PR, there are also some minor updates to the
installation-and-setup
docs.Resolves #1245.
@freekmurze @Gummibeer