Add feature to optionally gzip dumped .sql #424
Conversation
config/laravel-backup.php
Outdated
| /* | ||
| * Gzip the dumped SQL files for extra compression | ||
| */ | ||
| 'gzipSql' => false, |
src/Tasks/Backup/BackupJob.php
Outdated
| * @param $temporaryFilePath | ||
| * @return string | ||
| */ | ||
| protected function gzipSqlFile($dbDumper, $temporaryFilePath) |
There was a problem hiding this comment.
Refactor this to it's own class that is responsible for gzipping
|
Thanks for the feedback! I hope it's better now. |
src/Tasks/Backup/Gzip.php
Outdated
| gzwrite($gzipOut, fread($gzipIn, 1024 * 512)); | ||
| } | ||
| fclose($gzipIn); | ||
| } else { |
There was a problem hiding this comment.
I should have also mentioned that I really dislike else statements. Could you refactor this code to avoid them entirely?
|
Yeah I can see that, the error handling also didn't work correctly that way so I added a test for that and fixed it. Hope it's better now 😃 |
|
Cool, thanks Holding of on this for a while, because we might use gzip for compressing the other files as well. When I have some time on my hands I'll think this through. |
|
Hey @pdewit , thanks for doing this. As we only use the database backup feature, it's fine as it is, but I understand the plan from @freekmurze . (I know if I really want it, I should do it myself. Thanks for all your hard work guys) |
|
@afraca you can use my fork in the meantime, I'm not sure if it's going to be kept up to date but I will use it in production myself. https://github.com/pdewit/laravel-backup/tree/gzip-sql |
|
I've decided to merge this in so you can already make use of this. In the next major version (no ETA on that yet, probably early 2018) I plan to make this kind of compression a first class citizen in the package. |
According to issue #372, add an option to gzip the SQL files before zipping them. Very useful in my use case since .sql.gz files are a lot smaller while still able to be loaded into my SQL client, unlike .zip files.