This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
add getRouteKey method #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this? |
brendt
reviewed
Nov 30, 2017
src/HasBinaryUuid.php
Outdated
| @@ -90,4 +90,9 @@ public function newQueryForRestoration($id) | |||
| { | |||
| return $this->newQueryWithoutScopes()->whereKey(base64_decode($id)); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Remove trailing whitespace: https://styleci.io/analyses/zYabxo
tests/Feature/HasBinaryUuidTest.php
Outdated
| app('router')->get('uuid-test/{model}')->name('uuid-test'); | ||
|
|
||
| $expected = "http://localhost/uuid-test/$uuid"; | ||
| $actual = route('uuid-test', $model); |
There was a problem hiding this comment.
Add an extra line break here, see the style of other tests.
tests/Feature/HasBinaryUuidTest.php
Outdated
|
|
||
| app('router')->get('uuid-test/{model}')->name('uuid-test'); | ||
|
|
||
| $expected = "http://localhost/uuid-test/$uuid"; |
There was a problem hiding this comment.
Is hard-coding localhost the best idea? Maybe it would be better to assert like so?
$this->assertContains("/uuid-test/{$uuid}", $actual);
brendt
reviewed
Nov 30, 2017
tests/Feature/HasBinaryUuidTest.php
Outdated
| public function it_generates_valid_routes() | ||
| { | ||
| $uuid = Uuid::uuid1(); | ||
| $model = $this->createModel($uuid); |
There was a problem hiding this comment.
In some tests, these two lines are put together because there's a whole list of them. But in this case, I'd add a line break here.
|
Thanks! @freekmurze care to take a final look? |
|
Very nice! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently passing models to the
routemethod to generate a url will result in a malformed url as the binary uuid will be used.