This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
Add Logic to protectedByDemoMode method #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change protectedByDemoMode signature and add the logic.
|
Thanks you for your effort, but I'm not going to merge. This PR contains breaking changes. The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the protectedByDemoMode method signature and added the relevant logic.
Note that we can also delete this method since currently it always return true. But leaving it like that (with the logic added) is a kind of double checking.
Let me know if you want to delete it, I will update the pull request accordingly.