-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope support #4
Conversation
Some questions:
|
After spatie/enum:2.1.0 we don't need the mapping of values in the scopes anymore. Instead the scopes should also respect the possible cast to integer - introduced in 61e93c9 . |
@brendt I've opened this PR because it's now on |
@freekmurze could you check this PR? @brendt and I have written the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little nitpick
This PR is based on
model-support
for review. #1 must be merged before this one can target master.