Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting default queue settings #203

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

yaroslav-pohil
Copy link
Contributor

@yaroslav-pohil yaroslav-pohil commented Nov 27, 2023

This is follow-up for #197

Problem description
Queue check doesn't work properly when you name your queue other than default.

Problem details
The issue is that in laravel the default queue connection is stored as config('queue.default'), but this package calls config('queue. driver'). As a result, the package cannot find the connection config and selects default queue as one to check:

protected function getDefaultQueue($connection)
{
    return config("queue.connections.{$connection}.queue", 'default');
}

@freekmurze freekmurze merged commit 15e216d into spatie:main Nov 27, 2023
6 checks passed
@freekmurze
Copy link
Member

Thanks!

@yaroslav-pohil yaroslav-pohil deleted the fix-getting-default-queue branch November 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants