Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete attribute helper to input, select and textarea #219

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

raveren
Copy link
Contributor

@raveren raveren commented Mar 21, 2024

{{ html()->text('my_column')->placeholder(trans('my_column_placeholder'))->autocomplete('off') }}

@freekmurze freekmurze merged commit 4f418db into spatie:main Mar 23, 2024
@freekmurze
Copy link
Member

Very nice, thanks!

@raveren
Copy link
Contributor Author

raveren commented Mar 23, 2024

appreciated 🥰

@hyungseob
Copy link

form() doesn’t work yet. Are you planning to support it?

@raveren
Copy link
Contributor Author

raveren commented Apr 18, 2024

Oh I remember this one, I tried it out (putting autocomplete attribute on the form) and it didn't work as expected in the browser so I must have just skipped it. Hm, my bad sorry, it should be included.

I'll try to do a PR when I can :)

@raveren
Copy link
Contributor Author

raveren commented Apr 18, 2024

this is totally the wrong place to ask that and I'm not even a maintainer, but yeah id is predictably not generated automatically for button elements
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants