Fix deletion of files without extension (#3664)

spatie · Jul 15, 2024 · 38174fd · 38174fd
1 parent b091d25
commit 38174fd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Support/FileRemover/DefaultFileRemover.php b/src/Support/FileRemover/DefaultFileRemover.php
@@ -37,7 +37,7 @@ public function removeFromMediaDirectory(Media $media, string $disk): void
                     $imagePaths = array_filter(
                         $allFilePaths,
                         function (string $path) use ($media) {
-                            return Str::contains($path, pathinfo($media->file_name, PATHINFO_FILENAME).'.');
+                            return Str::afterLast($path, '/') === $media->file_name;
                         }
                     );
                     foreach ($imagePaths as $imagePath) {

diff --git a/tests/Feature/Media/DeleteTest.php b/tests/Feature/Media/DeleteTest.php
@@ -30,6 +30,16 @@
     expect(File::isDirectory($this->getMediaDirectory($media->id)))->toBeFalse();
 });
 
+it('will remove the files without extension', function () {
+    $media = $this->testModel->addMedia($this->getTestImageWithoutExtension())->toMediaCollection('images');
+
+    expect(File::isDirectory($this->getMediaDirectory($media->id)))->toBeTrue();
+
+    $media->delete();
+
+    expect(File::isDirectory($this->getMediaDirectory($media->id)))->toBeFalse();
+});
+
 it('will remove files when deleting a media object with a custom path generator', function () {
     config(['media-library.path_generator' => TestPathGenerator::class]);