S3 tests #384
Merged
S3 tests #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The teardown method that cleaned all the files uploaded to s3 doesn't work :/ I will investigate tomorrow night ! |
|
The open policy has been set, all stored objects are now publicly accessible. |
nicolasbeauvais
commented
Oct 24, 2016
| ); | ||
|
|
||
| if ($this->canTestS3) { | ||
| register_shutdown_function(function () { |
There was a problem hiding this comment.
Couldn't find a way to call Storage:: or app('filesystem.disk') in a ̀tearDownAfterCLassmethod, usingregister_shutdown_function` is the only working way that I found to clean the S3 bucket
|
Everything should work now 👍 But as you said my PR Travis build didn't have access to the S3 env vars |
|
I'll try out the test by merging your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #381
I tough it would be a good thing to test the file integrity in https://github.com/spatie/laravel-medialibrary/compare/master...nicolasbeauvais:s3-tests?expand=1#diff-bae027168159c1221823e2acf336b0b0R93
but the s3 bucket needs an open policy so that Travis-ci can read the file with
file_get_content()so it's commented for now.