Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detaching user models on teams feature #2220 #2221

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix detaching user models on teams feature #2220 #2221

merged 1 commit into from
Feb 6, 2023

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Oct 19, 2022

Maybe Closes #2220
So expecting comments, is there a better way?

@drbyte
Copy link
Collaborator

drbyte commented Oct 19, 2022

Would the trait in #1935 actually assist here?

@erikn69
Copy link
Contributor Author

erikn69 commented Oct 19, 2022

@drbyte not
#1935 handles teams deletion, this issue pops up on users deletion

@drbyte
Copy link
Collaborator

drbyte commented Oct 19, 2022

Oh, right. I had a "cascade" in mind when I was thinking about that.

@erikn69
Copy link
Contributor Author

erikn69 commented Oct 19, 2022

I had a "cascade" in mind

Yes, but on tests uses sqlite

@erikn69
Copy link
Contributor Author

erikn69 commented Oct 19, 2022

maybe unnecesary

@drbyte drbyte merged commit c931d4d into spatie:main Feb 6, 2023
@drbyte
Copy link
Collaborator

drbyte commented Feb 6, 2023

Thanks!

@erikn69 erikn69 deleted the bug_2220 branch February 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Teams when delete a user without soft delete trait, not all data gets detached
2 participants
@erikn69 @drbyte