use str_getcsv instead of explode in Delimited rule #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
str_getcsv
to convert the delimited list into an array allows escaping commas inside the list items.A real-life example would be list of email address specifications, ie:
"Doe, John" <johndoe@example.com>, "Doe, Jane" <janedoe@example.com>
.With the current implementation, the rule will break this into:
With
str_getcsv
, we get the expected result: