-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sheet to XLSX with Header-Row #124
Add new sheet to XLSX with Header-Row #124
Conversation
…ewrite a header with the new sheet. - also added the possibility to name the sheet
Could you add tests for this and add an example to the readme? |
@freekmurze there seems to be an issue with your Even if the files are copied, the following code will produce an assertion-error, if used for a xlsx. For a csv it works fine.
|
I see yopu changed to pest, but still the same
is not working |
@freekmurze wrote a test with the limitations mentioned above (there are in general no tests for xlsx as I can see), wrote an example for the README.md and added comments. Please review again. |
Thanks! |
The
processingFirstRow
property of the writer prevents the writer to automatically add a header row an newly created sheets by the underlaying writer. So this PR adds the method to the SimpleWriter and resets theprocessingFirstRow
-property.