Added addHeaderFromArray method to the SimpleWriter #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedus-creation
force-pushed
the
feature/add-header-from-array
branch
from
258ddcf
to
a7fb61b
Compare
|
Thank you! Could you remove all unrelated code style changes in this PR so I can easily see the actual changes? |
bedus-creation
force-pushed
the
feature/add-header-from-array
branch
from
b37abb6
to
fff52dd
Compare
|
@freekmurze Thanks for the quick response, I have updated the PR by removing unnecessary changes. |
freekmurze
requested changes
Dec 5, 2022
src/SimpleExcelWriter.php
Outdated
| @@ -127,6 +127,18 @@ public function addRows(iterable $rows, Style $style = null) | |||
| return $this; | |||
| } | |||
|
|
|||
| public function addHeaderFromArray(array $header): self | |||
|
Readme updated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no feature to directly add headers from the array. This PR adds
addHeaderFromArraymethod to the SimpleWriter, which allows to add headers from array.