Add test and fix conditional for #22. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyamsprod
reviewed
Feb 12, 2020
src/Ssh.php
Outdated
| @@ -111,7 +111,7 @@ protected function getExtraOptions(): string | |||
| $extraOptions[] = "-i {$this->pathToPrivateKey}"; | |||
| } | |||
|
|
|||
| if ($this->port) { | |||
| if (null !== $this->port) { | |||
There was a problem hiding this comment.
A port can not be a negative integer ... the usePort method should also be changed to throw exception for negative integer
freekmurze
requested changes
Feb 12, 2020
| @@ -1,3 +1,3 @@ | |||
| ssh user@example.com 'bash -se' << \EOF-SPATIE-SSH | |||
There was a problem hiding this comment.
This seems in correct, the -p flag should not appear if there is no specific port number.
There was a problem hiding this comment.
Right, missed that, fixed with the next commit.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test and fixed the corresponding conditional since 0 is a valid port number.