Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Ref stored as a string when it could be a structured map #75

Closed
goneall opened this issue Sep 4, 2020 · 1 comment
Closed

Cross-Ref stored as a string when it could be a structured map #75

goneall opened this issue Sep 4, 2020 · 1 comment
Assignees

Comments

@goneall
Copy link
Member

goneall commented Sep 4, 2020

currently, the cross-ref is a string which internally uses a JSON object format. When serialized, it currently looks as follows:

"crossRef": [
    "{url: https://joinup.ec.europa.eu/page/eupl-text-11-12,isValid: true,isLive: false,isWayBackLink: false,match: false,timestamp: 2020-09-04 - 15:25:56}",
    "{url: https://joinup.ec.europa.eu/sites/default/files/custom-page/attachment/eupl_v1.2_en.pdf,isValid: true,isLive: true,isWayBackLink: false,match: false,timestamp: 2020-09-04 - 15:25:58}"
  ],

This could be serialized as an object which would make it more usable by the reader:

"crossRef": [
    {"url: https://joinup.ec.europa.eu/page/eupl-text-11-12",isValid: true,isLive: false,isWayBackLink: false,match: false,timestamp: "2020-09-04 - 15:25:5},
    {"url: https://joinup.ec.europa.eu/sites/default/files/custom-page/attachment/eupl_v1.2_en.pdf",isValid: true,isLive: true,isWayBackLink: false,match: false,timestamp: "2020-09-04 - 15:25:58"}",
    "{url: https://joinup.ec.europa.eu/sites/default/files/inline-files/EUPL%20v1_2%20EN(1).txt,isValid: false,isLive: false,isWayBackLink: false,match: --,timestamp: 2020-09-04 - 15:25:59}
  ],
@goneall goneall mentioned this issue Sep 4, 2020
@goneall goneall self-assigned this Nov 12, 2020
goneall added a commit that referenced this issue Nov 13, 2020
… order

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall
Copy link
Member Author

goneall commented Nov 14, 2020

Resolved in PR #82

@goneall goneall closed this as completed Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant