Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator is warning on presumably valid values of external ref #171

Closed
loosebazooka opened this issue Apr 24, 2023 · 1 comment · Fixed by #172
Closed

Validator is warning on presumably valid values of external ref #171

loosebazooka opened this issue Apr 24, 2023 · 1 comment · Fixed by #172

Comments

@loosebazooka
Copy link
Contributor

It looks like

logger.warn("URI "+uri+" does not match any model object or enumeration");

is always triggered when reading in an externalRef.

I can't seem to find a value valid of external ref that wouldn't present this error (which is fairly harmless for our usecase, but it's a bit jarring to see all the warnings).

URI http://spdx.org/rdf/references/purl does not match any model object or enumeration
"externalRefs" : [ {
    "referenceCategory" : "PACKAGE-MANAGER",
    "referenceLocator" : "pkg:maven/org.apache.httpcomponents/httpclient@4.5.13",
    "referenceType" : "purl"
} ],

Am I using this incorrectly? Is the parser just warning out of abundance of caution?

goneall added a commit that referenced this issue Apr 25, 2023
Fixes #171

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall
Copy link
Member

goneall commented Apr 25, 2023

Thanks @loosebazooka for reporting this - we were missing a check which caused the warning. Turns out the only symptom of the missing check (fortunately) was the warning being generated.

I just created a PR which should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants