Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPL URLs to use https #1997

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix GPL URLs to use https #1997

merged 1 commit into from
Jun 9, 2023

Conversation

dorssel
Copy link
Contributor

@dorssel dorssel commented Jun 8, 2023

Scope:

  • all files GPL*.txt (not the deprecated ones)
  • URLs to fsf.org and gnu.org

Fixes #1995

@jlovejoy jlovejoy added the minor updates to file URL update, notes update, etc. label Jun 8, 2023
@jlovejoy jlovejoy added this to the 3.21 milestone Jun 8, 2023
@jlovejoy
Copy link
Member

jlovejoy commented Jun 8, 2023

Thanks @dorssel - looks like you included updates to deprecated ids (e.g., the two XML files) but, as those are deprecated and those corresponding .txt files do not contain https: - see https://github.com/spdx/license-list-XML/blob/main/test/simpleTestForGenerator/depreciate_GPL-3.0-with-GCC-exception.txt and https://github.com/spdx/license-list-XML/blob/main/test/simpleTestForGenerator/depreciate_GPL-3.0-with-autoconf-exception.txt
Could you just remove those two files from this PR?

Scope:

- all files GPL*.txt (not the deprecated ones)
- URLs to fsf.org and gnu.org
@dorssel dorssel removed their assignment Jun 8, 2023
@jlovejoy
Copy link
Member

jlovejoy commented Jun 9, 2023

Thanks @dorssel - I put you back as "assigned to" as that is how we track participation of PRs :)

@jlovejoy jlovejoy merged commit 6067f08 into spdx:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor updates to file URL update, notes update, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPL-3.0-only.txt out-of-sync with XML
2 participants