-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License Profile: add licenseListVersion to Creation Information #131
Comments
I've attended almost every Legal Team and Tech Team meeting during the last couple of years and don't recall this ever being a topic of discussion. As such I agree that it is probably an oversight; plus, I don't immediately see a reason why licenseListVersion would not still be relevant in SPDX 3.0.
|
It should be! It's an oversight. :) I'll need to understand a bit more about SPDX 3.0 to know which data field it should be tied to, but yes, this should be added. Thank you both for catching it! |
My initial reaction is that this property should apply to the SPDX Element which uses the License Expressions. It can be optional in the case where an SPDX Element does not contain any licensing-related information. |
Moving to 3.0, as I'll want to understand better how to incorporate this into CreationInfo and don't think we'll add that for 3.0-rc. |
I'll create a PR for this one |
Proposing we add this as a property to It seems that it would only be applicable for the expressions. I'll create a PR proposal once PR #444 is merged since it may cause a conflict. |
Fixes #131 This adds the licenseListVersion which in 2.3 was at the document level to the licenseExpression. Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Ah, @goneall, I am confused:
|
@zvr There are now two PR's - one for each proposal. We can choose one and throw the other away. Do you have an opinion on the newly created PR for the licenseExpression? |
Fixes #131 This adds the licenseListVersion which in 2.3 was at the document level to the licenseExpression. Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
In the SPDX 2.3 spec, the license list version used for an SPDX document is captured as specified in spec 6.7.
The current licensing-profile branch does not include a property of licenseListVersion or an extension to the CreationInformation class to include this as an optional property.
This may have just been an oversight.
The text was updated successfully, but these errors were encountered: