Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Profile: add licenseListVersion to Creation Information #131

Closed
goneall opened this issue Mar 20, 2023 · 8 comments · Fixed by #481
Closed

License Profile: add licenseListVersion to Creation Information #131

goneall opened this issue Mar 20, 2023 · 8 comments · Fixed by #481
Assignees
Milestone

Comments

@goneall
Copy link
Member

goneall commented Mar 20, 2023

In the SPDX 2.3 spec, the license list version used for an SPDX document is captured as specified in spec 6.7.

The current licensing-profile branch does not include a property of licenseListVersion or an extension to the CreationInformation class to include this as an optional property.

This may have just been an oversight.

@seabass-labrax
Copy link

seabass-labrax commented Mar 20, 2023 via email

@swinslow
Copy link
Member

It should be! It's an oversight. :) I'll need to understand a bit more about SPDX 3.0 to know which data field it should be tied to, but yes, this should be added. Thank you both for catching it!

@seabass-labrax
Copy link

My initial reaction is that this property should apply to the SPDX Element which uses the License Expressions. It can be optional in the case where an SPDX Element does not contain any licensing-related information.

@swinslow
Copy link
Member

swinslow commented May 5, 2023

Moving to 3.0, as I'll want to understand better how to incorporate this into CreationInfo and don't think we'll add that for 3.0-rc.

@swinslow swinslow added this to the 3.0 milestone May 5, 2023
@goneall goneall modified the milestones: 3.0, 3.0-rc2 Jul 28, 2023
@goneall
Copy link
Member Author

goneall commented Jul 28, 2023

I'll create a PR for this one

@goneall goneall self-assigned this Jul 28, 2023
@goneall
Copy link
Member Author

goneall commented Jul 31, 2023

Proposing we add this as a property to LicenseExpression as suggested by @seabass-labrax

It seems that it would only be applicable for the expressions.

I'll create a PR proposal once PR #444 is merged since it may cause a conflict.

goneall added a commit that referenced this issue Aug 17, 2023
Fixes #131

This adds the licenseListVersion which in 2.3 was at the document
level to the licenseExpression.

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@zvr
Copy link
Member

zvr commented Aug 18, 2023

Ah, @goneall, I am confused:

  • you write "Proposing we add this as a property to LicenseExpression"
  • there is a commit automatically mentioned above that references this
  • but the PR automatically mentioned above adds it to CreationInfo instead...

@goneall
Copy link
Member Author

goneall commented Aug 18, 2023

@zvr There are now two PR's - one for each proposal. We can choose one and throw the other away.

Do you have an opinion on the newly created PR for the licenseExpression?

goneall added a commit that referenced this issue Aug 25, 2023
Fixes #131

This adds the licenseListVersion which in 2.3 was at the document
level to the licenseExpression.

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment