Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenseListVersion back to CreationInfo #480

Closed
wants to merge 2 commits into from
Closed

Conversation

goneall
Copy link
Member

@goneall goneall commented Aug 17, 2023

This fixes #131

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall requested review from zvr and swinslow August 17, 2023 19:47
@goneall goneall added this to the 3.0-rc2 milestone Aug 17, 2023
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@zvr
Copy link
Member

zvr commented Aug 18, 2023

I have some reservations about adding this to CreationInfo for every Element (although it will not be mandatory). We had some discussions on dataLicense on that.

We really want it for things that have licenses -- or, more precisely, not even for licensed things but for the license expressions themselves. So why don't we make it a property of these?

@goneall
Copy link
Member Author

goneall commented Aug 18, 2023

I have some reservations about adding this to CreationInfo for every Element (although it will not be mandatory). We had some discussions on dataLicen

In anticipation of this - I've already prepared an alternative proposal to add it to just the license expression in SimpleLicensingInfo.

I'll create a pull request for review.

@goneall
Copy link
Member Author

goneall commented Aug 18, 2023

Change to draft status until we decide which PR to merge.

@goneall goneall marked this pull request as draft August 18, 2023 16:44
@goneall
Copy link
Member Author

goneall commented Aug 19, 2023

Closing this PR as #481 is the preferred solution to the license list version.

@goneall goneall closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License Profile: add licenseListVersion to Creation Information
2 participants