Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PackageVerificationCode to have algorithm explicit #646

Closed
kestewart opened this issue Feb 17, 2024 · 3 comments
Closed

Update PackageVerificationCode to have algorithm explicit #646

kestewart opened this issue Feb 17, 2024 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation Profile:Core
Milestone

Comments

@kestewart
Copy link
Contributor

In #643 the PackageVerificationCode model had the algorithm, but the text for the class had it hardcoded as SHA1. The model was updated to match, but the algorithm should be put back into the diagram & the description of packageVerificationCode rewritten to include use of algorithms other than SHA1.

@kestewart kestewart added bug Something isn't working documentation Improvements or additions to documentation Profile:Core labels Feb 17, 2024
@kestewart kestewart added this to the 3.0 milestone Feb 17, 2024
@goneall goneall modified the milestones: 3.0, 3.0-rc3 Mar 4, 2024
@kestewart
Copy link
Contributor Author

kestewart commented Mar 28, 2024

Screenshot 2024-03-28 at 11 04 03 AM

Need to get example to see how this is able to express with different HASH algorithms - I think we need to add in the "algorithm field" to the class. Thoughts?

@kestewart
Copy link
Contributor Author

DIscussion from the call, preference is to replicate algoirthm in PackageVerificaitonCode.

PR will be submitted.

@goneall
Copy link
Member

goneall commented Apr 6, 2024

Resolved with PR #699

@goneall goneall closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation Profile:Core
Projects
None yet
Development

No branches or pull requests

2 participants