-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PackageVerificationCode.md #699
Conversation
Add in Algorithm, and rework algorithm example to use example fields.
This addresses #646 |
I thought that the algorithm was fixed to |
@maxhbr you raise a good point. I'm OK either way as this is just for legacy purposes. It may be easier to migrate if we don't have the property and just define it as SHA1 since we don't have an algorithm property in 2.3. @kestewart - thoughts? |
It had been talked about using SHA256 as this will be more common than SHA1. At this point, prefer to leave it flexible with "algorithm", and can restrict it if necessary going forward. |
we describe the PackageVerificationCode with
In my opinion, this makes complicated code that seldomly gets implemented correctly more complex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but I think this should not be merged.
Also the V2->V3 migration guide would need to be adopted for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - consistent with discussions on tech call
Add in Algorithm, and rework algorithm example to use example fields.
Signed-off-by: Kate Stewart kstewart@linuxfoundation.org