Fix cardinality of (primary)Purpose #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #133 Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
kestewart
approved these changes
May 7, 2023
There was a problem hiding this comment.
I think we still need a Purpose field with the original cardinality. Specifically there are use cases when you have a something that is "primary", but others may want to find "secondary" elements as well. Example - primary of "evidence", secondary of "data". primary of "operatingSystem", secondary of "executable", etc.
kestewart
requested changes
May 16, 2023
|
Multiple purposes is planned to be used in the Safety profile, therefore we should add back purpose with multiple cardinalities. |
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
|
I added the field |
|
@kestewart Please review |
kestewart
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
This PR just renames purpose to primaryPurpose and changes the cardinality to 0..1 to be consistent with SPDX 2.3 and support the CycloneDX translation.