Validating an SPDX file with colon in name fails

[vargenau]

In the online validator, I try to validate a file called mariadb:latest.spdx

I get a banner with the following error message:

File /spdx/src/app/media/AnonymousUser/1654771839/mariadb%3Alatest.spdx not found.

[rtgdk]

@vargenau Which OS are you on when you upload this file? colon are not prohibited in windows world. Can you try without colon filename?

[vargenau]

It was a Linux machine, Ubuntu.

The bug is that the colon ":" has been encoded as "%3A". It should not have been.

[BanulaKumarage]

Hi, @rtgdk I am working on a windows environment. As you said, colons are prohibited in windows. Does this error occur in other characters except for the colon? If so I can try with that to reproduce the error. Otherwise is there any other way to reproduce this error? Please assist me on this.

[vargenau]

Yes, colons (and some other characters) are forbidden on Windows.
But colons are legal on Unix/Linux.
That is precisely the issue, you should not fail in that case.

[rtgdk]

@BanulaKumarage You can try to download a file which has colon in it's name and try opening it in Windows or through the onlint tool. You should be able to reproduce it.

There should a way to escape colon character or rename it before opening in windows.

[BanulaKumarage]

Thanks @rtgdk I will try that

[BanulaKumarage]

Recreated the issue. Working on it

[BanulaKumarage]

@rtgdk @vargenau Made PR #460 to fix this. Please review.

[vargenau]

Hi @BanulaKumarage
I cannot test if the fix is not deployed.

[vargenau]

Has the fix been deployed on https://tools.spdx.org/app/validate/ ?

I still have the error.

[BanulaKumarage]

Has the fix been deployed on https://tools.spdx.org/app/validate/ ?

I still have the error.

Its not merged it yet.

[vargenau]

This has been fixed in https://github.com/spdx/spdx-online-tools/releases/tag/v1.2.1

You can close the ticket.